[Finder] Add early directory prunning filter support #50877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0117bc0 to
2cb6ad5
Compare
2cb6ad5 to
c47a9b8
Compare
74945e2 to
b5dd592
Compare
src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php
Outdated
Show resolved
Hide resolved
2cdcbf7 to
4864bea
Compare
4864bea to
6cdfe93
Compare
nicolas-grekas
approved these changes
Jul 13, 2023
45d034d to
baca842
Compare
|
@mvorisek Can you rebase to resolve the conflicts? |
baca842 to
840cb28
Compare
|
Thank you @mvorisek. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 16, 2023
…er support (mvorisek) This PR was merged into the 6.4 branch. Discussion ---------- [Finder] [Finder docs] Add early directory prunning filter support Refs * symfony/symfony#50877 Commits ------- 4b08ee6 [Finder docs] Add early directory prunning filter support
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering terminology first:
Currently there is early directory prunning support possible, but with string patterns only, not even full regex is supported as the input is always quoted - https://github.com/symfony/symfony/blob/v6.2.12/src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php#L45.
This PR adds early directory prunning with full callback support.
Tested with VFS to assert the pruned directories are really not traversed and the count of IO syscalls is minimal.