Add native return types to fix compat with v7 #50890
Conversation
nicolas-grekas
commented
Jul 5, 2023
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php
Outdated
Show resolved
Hide resolved
e7c4be9 to
133bb13
Compare
src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/ConcreteMicroKernel.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/flex-style/src/FlexStyleMicroKernel.php
Outdated
Show resolved
Hide resolved
e9fef32 to
404ea2f
Compare
There was a problem hiding this comment.
All green, PR is ready.
What this does is adding a few return types on some selected classes on 6.4.
Technically, this is a BC break, but I think the patched methods have a very low chance of being overridden in a child class.
Note that while preparing this PR, I reverted some native return types on 7.0 as well, see full list in:
https://github.com/symfony/symfony/blob/7.0/.github/expected-missing-return-types.diff
Alternatively to this PR, we could revert more native return types on 7.0, and we could also declare v6 and v7 as being incompatible for the related packages. This is a matter of finding the sweet spot between those approaches, and this PR is my proposal :)
I'm merging it now to unlock the CI, but feel free to discuss the topic even after merge, we still have a few months to adjust this before the release.