Skip to content

[Validator] Do not mock metadata factory on debug command tests #50935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Validator] Do not mock metadata factory on debug command tests #50935

merged 1 commit into from
Jul 13, 2023

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Jul 11, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? not really, but it will be usefull to fix that command
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Before #48840 I think this one could improve the tests.

@carsonbot carsonbot added this to the 5.4 milestone Jul 11, 2023
@loic425 loic425 mentioned this pull request Jul 11, 2023
Merged
@macintoshplus
Copy link
Contributor

This PR help me with this one #48840

@nicolas-grekas nicolas-grekas force-pushed the fix/do-not-mock-metadata-factory branch from 2c47083 to de6d15f Compare July 13, 2023 13:58
@nicolas-grekas
Copy link
Member

Thank you @loic425.

@nicolas-grekas nicolas-grekas merged commit 67acf9e into symfony:5.4 Jul 13, 2023
@loic425 loic425 deleted the fix/do-not-mock-metadata-factory branch July 13, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@loic425 @macintoshplus @nicolas-grekas @carsonbot