Skip to content

[Intl] Taking into account bibliographic + overlong #50943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Intl] Taking into account bibliographic + overlong #50943

merged 1 commit into from
Jul 13, 2023

Conversation

oleg-andreyev
Copy link
Contributor

@oleg-andreyev oleg-andreyev commented Jul 11, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50142
License MIT
Doc PR -

When building Alpha3 and aliases take into account bibliographic type.

@carsonbot carsonbot added this to the 6.4 milestone Jul 11, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@oleg-andreyev oleg-andreyev changed the base branch from 6.4 to 5.4 July 11, 2023 20:18
@oleg-andreyev
Copy link
Contributor Author

fabbot is failing https://fabbot.io/report/symfony/symfony/50943/a87c5067c97993d87929f8f14fdee7d8c45f9678 trying to change dum to dumb

@oleg-andreyev oleg-andreyev changed the title Issue 50142 [Intl] Taking into account bibliographic + overlong Jul 11, 2023
@oleg-andreyev
Copy link
Contributor Author

@fabpot @nicolas-grekas

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 5.4 Jul 12, 2023
stof
stof reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't generateAlpha3Codes be updated to include them as well ?

@oleg-andreyev
Copy link
Contributor Author

shouldn't generateAlpha3Codes be updated to include them as well ?

I agree with @ro0NL, T codes are preferable, B are considered legacy.

#50943 (comment)

@oleg-andreyev
Copy link
Contributor Author

I'll squash commits before merge.

nicolas-grekas
nicolas-grekas approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please squash if you can yes)

@carsonbot carsonbot changed the title [Intl] Taking into account bibliographic + overlong Taking into account bibliographic + overlong Jul 13, 2023
@oleg-andreyev
Copy link
Contributor Author

(please squash if you can yes)

One commit is related to update-data on MacOS (fix)
Second is actually about this ticket.

I hope it's okay (prefer more or less clean and separate history)

@nicolas-grekas
Copy link
Member

We always squash so that one PR=one commit. This is the same topic :)

@oleg-andreyev
Copy link
Contributor Author

We always squash so that one PR=one commit. This is the same topic :)

Not a problem, now one commit.

@carsonbot carsonbot changed the title Taking into account bibliographic + overlong [Intl] Taking into account bibliographic + overlong Jul 13, 2023
@nicolas-grekas
Copy link
Member

Thank you @oleg-andreyev.

@nicolas-grekas nicolas-grekas merged commit a056e7b into symfony:5.4 Jul 13, 2023
@oleg-andreyev oleg-andreyev deleted the issue_50142 branch July 13, 2023 09:07
This was referenced Jul 29, 2023
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Nov 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@ro0NL ro0NL Awaiting requested review from ro0NL

Assignees
No one assigned
Labels
Bug Intl Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Intl] nl language can be represented as dut and nld
5 participants
@oleg-andreyev @carsonbot @nicolas-grekas @stof @ro0NL