Skip to content

[Messenger] do not listen to signals if the pcntl extension is missing #50963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Messenger] do not listen to signals if the pcntl extension is missing #50963

merged 1 commit into from
Jul 13, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 13, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.3 milestone Jul 13, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Jul 13, 2023

caused by the changes done in #49539, previously we exited early when the pcntl_signal() function was missing

@nicolas-grekas
Copy link
Member

Could the failing integration test be related?

  1. Symfony\Component\Messenger\Bridge\Amqp\Tests\Transport\AmqpExtIntegrationTest::testItReceivesSignals
    RuntimeException: Expected output never arrived. Got "" instead.

It's not on the latest 6.3 run.

@xabbuh
Copy link
Member Author

xabbuh commented Jul 13, 2023

I am looking into the failure

@lyrixx
Copy link
Member

lyrixx commented Jul 13, 2023

There is a competitive PR

#50787

@xabbuh
Copy link
Member Author

xabbuh commented Jul 13, 2023

@nicolas-grekas tests fixed

@lyrixx This PR fixes an issue when this listener is registered by the FrameworkBundle 5.4, but the pcntl extension is missing. I don't see how this is being fixed by the linked PR.

@lyrixx
Copy link
Member

lyrixx commented Jul 13, 2023

ah okay, I confused.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 8cbe646 into symfony:6.3 Jul 13, 2023
@xabbuh xabbuh deleted the pr-49539 branch July 13, 2023 13:27
@fabpot fabpot mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @lyrixx @OskarStark @carsonbot