[Intl] Fixed directory traversal in emoji compression tool #51030
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
| $file_iterator = new RecursiveIteratorIterator( | ||
| new RecursiveDirectoryIterator( | ||
| dirname(__DIR__).'/data', | ||
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | ||
| ) | ||
| ); | ||
|
|
||
| foreach ($file_iterator as $file) { |
There was a problem hiding this comment.
we use camelCase for variables:
| $file_iterator = new RecursiveIteratorIterator( | |
| new RecursiveDirectoryIterator( | |
| dirname(__DIR__).'/data', | |
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | |
| ) | |
| ); | |
| foreach ($file_iterator as $file) { | |
| $iterator = new RecursiveIteratorIterator( | |
| new RecursiveDirectoryIterator( | |
| dirname(__DIR__).'/data', | |
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | |
| ) | |
| ); | |
| foreach ($iterator as $file) { |
|
Thanks for the update. Can you please squash the two commits in one? I would have done it but "Allow edits from maintainer" is disabled so I can't. |
When using the compression tool, the emoji data is not compressed properly due to directory traversal issues. It only goes one level deep in the `data' directory.
|
Thanks for your feedback, Nicolas. I just squashed the two commits into one. |
|
Thank you @rlandgrebe. |
When using the compression tool, the emoji data is not compressed properly due to directory traversal issues. It only goes one level deep in the `data' directory.