Skip to content

[Routing] Fix testMissingPrefixLocale and testMissingRouteLocale #51084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 24, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #51082 (comment)
License MIT
Doc PR not needed

Those two fixtures only exist as annotation versions. Their attribute counterparts were missing.

The corresponding tests only expected a LogicException which is what AnnotationClassLoader would raise for undefined classes as well.

This PR adds new assertions for the exception messages which would have discovered the missing fixtures. Finally, the two missing fixtures are added.

@carsonbot carsonbot added this to the 5.4 milestone Jul 24, 2023
@derrabus derrabus changed the title [Routing] Fix testMissingPrefixLocale and testMissingRouteLocale [Routing] Fix testMissingPrefixLocale and testMissingRouteLocale Jul 24, 2023
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 8b82019 into symfony:5.4 Jul 24, 2023
@derrabus derrabus deleted the bugfix/prefix-locale-tests branch July 24, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants