Skip to content

[FrameworkBundle][Workflow] Remove unused code #51089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 24, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 7.0 milestone Jul 24, 2023
@carsonbot carsonbot changed the title [FrameworkBundle][Workflow] Remove dead code [FrameworkBundle][Workflow] Remove unused code Jul 24, 2023
@@ -81,10 +81,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$type = $workflow instanceof StateMachine ? 'state_machine' : 'workflow';
$definition = $workflow->getDefinition();

if (null === $definition) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can never be null. It's a left over from #50873

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit e7db158 into symfony:7.0 Jul 24, 2023
@lyrixx lyrixx deleted the workflow-clean-7 branch July 24, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants