Skip to content

[PsrHttpMessageBridge] Import the bridge into the monorepo #51100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 159 commits into from
Jul 30, 2023

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR TODO

⚠️ Don't squash!

I propose to import the symfony/psr-http-message-bridge package into the Symfony monorepo for further maintenance.

fabpot and others added 30 commits May 21, 2015 18:30
This PR was squashed before being merged into the 2.8-dev branch (closes #1).

Discussion
----------

Initial support

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs#5331

- [x] Composer dependencies
- [x] Interfaces
- [x] Stub
- [x] HttpFoundationFactory implementation
- [x] DiactorosFactory implementation
- [x] StreamedResponse

Commits
-------

ca41146 Initial support
This PR was merged into the master branch.

Discussion
----------

Test Diactoros Factory with PHP 5.4

They now support PHP 5.4 too.

Commits
-------

bab1530 Test Diactoros Factory with PHP 5.4
…KorvinSzanto)

This PR was merged into the master branch.

Discussion
----------

Remove use of deprecated 'deep' parameter in tests

This allows the tests to complete when using the symfony 3.0 version of http-foundation.

Commits
-------

305c0fe Remove use of deprecated 'deep' parameter
This PR was squashed before being merged into the master branch (closes symfony#18).

Discussion
----------

Allow multiple calls to Request::getContent()

The Symfony request throws a LogicException if getContent() is called more than once and the first time with parameter "true". If $symfonyRequest->getContent(true) has thrown the exception, the call to $symfonyRequest->getContent() will do the same again.

Commits
-------

9624b8b Allow multiple calls to Request::getContent()
Fixed PHP 5.3.3 array syntax
…(ahundiak, Danielss89)

This PR was merged into the master branch.

Discussion
----------

Fixes symfony#9 Bridge error when no file is selected

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	symfony#9
License	MIT
Doc PR

Commits
-------

a1a631a Update assert error message
e5d62e6 Fixes based on code-review
101b608 Handles null file in createrequest bridge.
…RI (rougin)

This PR was squashed before being merged into the master branch (closes symfony#22).

Discussion
----------

Fixes symfony#16 Symfony Request created without any URI

| Q | A |
| ------------- |:-------------:|
| Bug fix? | Yes |
| New feature? | No |
| BC breaks? | No |
| Depreciations? | No |
| Tests pass? | Yes |
| Fixed tickets | [symfony#16](https://github.com/symfony/psr-http-message-bridge/issues/16) |
| License | MIT |
| Doc PR | N/A |

Commits
-------

a59c572 Fixes symfony#16 Symfony Request created without any URI
This PR was merged into the master branch.

Discussion
----------

Fix REQUEST_METHOD on symfony request

Commits
-------

98ab85a Fix REQUEST_METHOD on symfony request
This PR was merged into the 1.0-dev branch.

Discussion
----------

test suite compatibility with PHPUnit 6

Commits
-------

f5c46f0 test suite compatibility with PHPUnit 6
This PR was merged into the 1.0-dev branch.

Discussion
----------

Allow Symfony 4

Commits
-------

97635f1 Allow Symfony 4
@derrabus
Copy link
Member Author

fabbot complains about the merge commit. I'd like to keep that merge commit in order to keep the original history intact.

@derrabus derrabus force-pushed the feature/psr-http-message-bridge branch from 3b5b4e4 to 84a0935 Compare July 25, 2023 15:58
nicolas-grekas and others added 4 commits July 26, 2023 10:47
…arsed body (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

Don't rely on Request::getPayload() to populate the parsed body

That's just not needed and creates issues like symfony#121

+ fixes a bug with invalid jsons.

Commits
-------

ef03b6d Don't rely on Request::getPayload() to populate the parsed body
@derrabus derrabus force-pushed the feature/psr-http-message-bridge branch from 84a0935 to 54478cf Compare July 26, 2023 13:51
…0de5ff08ee1ba6850a0ee472e'

git-subtree-dir: src/Symfony/Bridge/PsrHttpMessage
git-subtree-mainline: 510e51f
git-subtree-split: 581ca60
@derrabus derrabus force-pushed the feature/psr-http-message-bridge branch from 54478cf to c21b1bd Compare July 27, 2023 17:33
@derrabus derrabus force-pushed the feature/psr-http-message-bridge branch from c21b1bd to e40dd66 Compare July 27, 2023 18:30
@fabpot
Copy link
Member

fabpot commented Jul 30, 2023

Thank you @derrabus.

@fabpot fabpot merged commit 0b44a27 into symfony:6.4 Jul 30, 2023
@derrabus derrabus deleted the feature/psr-http-message-bridge branch July 30, 2023 09:41
fabpot added a commit that referenced this pull request Jul 31, 2023
…omponents (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[PsrHttpMessageBridge] Streamline README.md with other components

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Follows #51100
| License       | MIT
| Doc PR        | not needed

Commits
-------

5635e86 [PsrHttpMessageBridge] Streamline README.md with other components
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.