Skip to content

[Form] Remove an obsolete phpdoc comment #51110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Jul 26, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

It seems that the comment was introduced when renaming guessMinLength to guessPattern 11 years ago (f7200e4#diff-c8f9f12ae6d4b48f0f41c30c0cd9716c41e92563a7ded52264a0eb3540ad04e5).
However the comment seems to be about a min length, as is it brings to value when guessing a pattern IMHO, so let's drop it.

@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit b69cde8 into symfony:5.4 Jul 26, 2023
@HeahDude HeahDude deleted the remove-obsolete-comment branch July 27, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants