Skip to content

[Mailer] update the Brevo SMTP host #51119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 26, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51118
License MIT
Doc PR

see https://developers.brevo.com/docs/changes-in-smtp-relay-address

@xabbuh
Copy link
Member Author

xabbuh commented Jul 26, 2023

ping @PEtanguy

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 649c8a1 into symfony:6.4 Jul 26, 2023
@xabbuh xabbuh deleted the issue-51118 branch July 27, 2023 06:24
@bastien-wink
Copy link
Contributor

@xabbuh @nicolas-grekas Could this be also part of lower versions of symfony ? According to the email bellow the current SMTP will be terminated this month.

image

I will get in touch with Brevo to know exactly how long they will support the old hostname.

@fabpot
Copy link
Member

fabpot commented Aug 5, 2023

My answer would be that if a commercial product doesn’t care about making their user lives easier, I don’t see why we should. Anyway, I suppose we would accept a PR doing the needed changes in 6.3.

@bastien-wink
Copy link
Contributor

Indeed they don't care about their customers, I've done my best to have a clear answer, all we have is "that might impact the good fonction of your transactional sending".

I created a PR for 6.3 #51295

For the record :
image

@stof
Copy link
Member

stof commented Aug 8, 2023

Given that the new Brevo bridge won't be released until November (as it was merged in 6.4 and not in 6.3), I suggest merging that as a bugfix (and maybe even in the 5.4 LTS instead of having a non-working bridge as LTS)

fabpot added a commit that referenced this pull request Aug 8, 2023
This PR was submitted for the 6.3 branch but it was merged into the 5.4 branch instead.

Discussion
----------

[Mailer] update Brevo SMTP host

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #51118
| License       | MIT

Backporting #51119 into 6.3.

See https://developers.brevo.com/docs/changes-in-smtp-relay-address
We don't know the termination date for the legacy sendinblue SMTP, it's safer to update it.

Commits
-------

c85892c [Mailer] update Brevo SMTP host
@fabpot
Copy link
Member

fabpot commented Aug 8, 2023

I've merged the PR in 5.4.

@stof
Copy link
Member

stof commented Aug 8, 2023

@fabpot given that the previous host will stop working on August 30th, it would be great also to do a patch release (for 5.4 and 6.3) soon enough to give projects a bit of time to update this bridge before the deadline is reached so that it keeps working.

@kgonella
Copy link
Contributor

Hello, do we have a chance that a patch release will be available before August 30th ?

@fabpot
Copy link
Member

fabpot commented Aug 22, 2023

We make releases at the end of each month. So, the next release cycle will happen at the end of August.
But then again, I don't see why we should rush things out on our side because of a commercial company that doesn't care about their customers.

@derrabus
Copy link
Member

derrabus commented Aug 22, 2023

Until we tag a new release, use a dev snapshot:

"require": {
    "symfony/sendinblue-mailer": "~6.3.4@dev"
}

or switch to the new package:

"require": {
    "symfony/brevo-mailer": "^6.4@dev"
}

@stof
Copy link
Member

stof commented Aug 22, 2023

@derrabus switching to brevo-mailer also requires switching to framework-bundle 6.4.x-dev, otherwise the wiring won't be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in SMTP relay address
8 participants