[Scheduler] Postpone schedule creation #51138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Jul 28, 2023
| @@ -133,7 +133,7 @@ | |||
| "doctrine/data-fixtures": "^1.1", | |||
| "doctrine/dbal": "^2.13.1|^3.0", | |||
| "doctrine/orm": "^2.12", | |||
| "dragonmantank/cron-expression": "^3", | |||
| "dragonmantank/cron-expression": "^3.1", | |||
There was a problem hiding this comment.
Sync up with src/Symfony/Component/Scheduler/composer.json, lowest deps fail otherwise.
fabpot
approved these changes
Jul 29, 2023
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is caused by the
MessengerTransportDoctrineSchemaListenerwhich is triggered whendoctrine:schema:createis run. It instantiates all transports which causes theScheduleProviderInterface::getSchedule()method to be called, but since the schema is not yet created, everything breaks.This PR changes the
MessageGeneratorclass to accept theScheduleProviderInterfaceinstead of onlySchedule. That way the call togetSchedule()can be postponed to when it's really needed, and since theSheduleclass implements theScheduleProviderInterface, there's no breaking change.