Skip to content

[Notifier] [Docs] Fix update slack messages documentation #51158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2023
Merged

[Notifier] [Docs] Fix update slack messages documentation #51158

merged 1 commit into from
Jul 30, 2023

Conversation

franmomu
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

UpdateMessageSlackOptions receives a channel id and message id:

public function __construct(string $channelId, string $messageId, array $options = [])

The method getFullMessageId() does not exists, it is getMessageId()

public function getMessageId(): ?string

@franmomu franmomu requested a review from OskarStark as a code owner July 29, 2023 14:21
@carsonbot carsonbot added this to the 6.3 milestone Jul 29, 2023
@carsonbot carsonbot changed the title [Notifier][Docs] Fix update slack messages documentation [Notifier] [Docs] Fix update slack messages documentation Jul 29, 2023
@fabpot
Copy link
Member

fabpot commented Jul 30, 2023

Thank you @franmomu.

@fabpot fabpot merged commit f664706 into symfony:6.3 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants