Skip to content

[6.3] Fix symfony/deprecation-contracts require #51174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[6.3] Fix symfony/deprecation-contracts require #51174

merged 1 commit into from
Jul 31, 2023

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follow-up to #51151

@carsonbot carsonbot added this to the 6.3 milestone Jul 31, 2023
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 07d96ed into symfony:6.3 Jul 31, 2023
@fancyweb fancyweb deleted the fix-deprec-req-63 branch July 31, 2023 07:15
@GrahamCampbell
Copy link
Contributor

This change was missed from the 6.3.3 changelog. cc @fabpot

@nicolas-grekas
Copy link
Member

it was merged as "minor", thus no lines in the changelog

@fancyweb fancyweb mentioned this pull request Oct 19, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Oct 19, 2023
@nicolas-grekas
minor #52178 [Messenger] Fix requiring symfony/deprecation-contracts …
7b48483 
…(fancyweb)

This PR was merged into the 6.3 branch.

Discussion
----------

[Messenger] Fix requiring symfony/deprecation-contracts

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT

In #51174 I added it by mistake in require-dev instead of require 🤦‍♂️

Commits
-------

7cd5576 [Messenger] Fix requiring symfony/deprecation-contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @GrahamCampbell @carsonbot