Skip to content

CI: Disable Psalm's findUnusedBaselineEntry feature #51175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 31, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Psalm has introduced a feature for detecting unused entries in the error baseline. This is useful for a baseline that is maintained along with the code because it tells the developer when the baseline starts to smell and needs to be regenerated.

However, we use the baseline differently: We generate the baseline on the fly in order to check if a PR introduces new errors. Failing on baseline entries that can be purged is not what we want in that case because a contributor cannot fix those errors.

Example for a Psalm run that failed because of unused baseline entries: https://github.com/symfony/symfony/actions/runs/5706412328/job/15462071408

@carsonbot carsonbot added this to the 5.4 milestone Jul 31, 2023
@derrabus derrabus changed the title CI: Disable Psalm's findUnusedBaselineEntry feature CI: Disable Psalm's findUnusedBaselineEntry feature Jul 31, 2023
@derrabus derrabus merged commit efff124 into symfony:5.4 Jul 31, 2023
@derrabus derrabus deleted the fix/psalm-unused-baseline branch July 31, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants