Skip to content

[Workflow] fix MermaidDumper when place contains special char #51201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 1, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

If a place contains a special char, like a space ( ), mermaid is not able to render it.
See this example

I faced this bug with this workflow

I manually tested in mermaid.live all dumped workflows from our tests suite, and they are OK

And I'll need this naming predictability for an upcoming PR

@fabpot
Copy link
Member

fabpot commented Aug 1, 2023

Thank you @lyrixx.

@fabpot fabpot merged commit f299846 into symfony:5.4 Aug 1, 2023
@lyrixx lyrixx deleted the workflow-mermaid-fix branch August 1, 2023 09:05
This was referenced Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants