[HttpFoundation] Use Symfony exception for request unexpected values #51252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d4b035 to
06eb999
Compare
nicolas-grekas
approved these changes
Aug 3, 2023
| @@ -184,7 +185,7 @@ public function getEnum(string $key, string $class, \BackedEnum $default = null) | |||
| try { | |||
| return $class::from($value); | |||
| } catch (\ValueError|\TypeError $e) { | |||
| throw new \UnexpectedValueException(sprintf('Parameter "%s" cannot be converted to enum: %s.', $key, $e->getMessage()), $e->getCode(), $e); | |||
| throw new UnexpectedValueException(sprintf('Parameter "%s" cannot be converted to enum: "%s".', $key, $e->getMessage()), $e->getCode(), $e); | |||
There was a problem hiding this comment.
Suggested change
| throw new UnexpectedValueException(sprintf('Parameter "%s" cannot be converted to enum: "%s".', $key, $e->getMessage()), $e->getCode(), $e); | |
| throw new UnexpectedValueException(sprintf('Parameter "%s" cannot be converted to enum: %s.', $key, $e->getMessage()), $e->getCode(), $e); |
There was a problem hiding this comment.
The ci fail without this change
There was a problem hiding this comment.
I reverted @derrabus @nicolas-grekas
derrabus
approved these changes
Aug 3, 2023
df327be to
72e374d
Compare
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #51196
Cf #51196 (comment)
cc @nicolas-grekas