Skip to content

[Composer] Bumped doctrine/orm to 2.2.3 #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2012
Merged

[Composer] Bumped doctrine/orm to 2.2.3 #5127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
"require-dev": {
"doctrine/dbal": ">=2.2,<2.4-dev",
"doctrine/orm": ">=2.2,<2.4-dev",
"doctrine/orm": ">=2.2.3,<2.4-dev",
"doctrine/data-fixtures": "1.0.*",
"propel/propel1": "dev-master",
"monolog/monolog": "dev-master"
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Doctrine/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"symfony/validator": "self.version",
"doctrine/data-fixtures": "1.0.*",
"doctrine/dbal": ">=2.2,<2.4-dev",
"doctrine/orm": ">=2.2,<2.4-dev"
"doctrine/orm": ">=2.2.3,<2.4-dev"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this is not enough. ORM 2.2.3 could accept common 2.2.2. and the real 2.2.3 requirement is on Common in the bridge (thus, this does not change anything there as it is in the suggestion which is simply plain text)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof there seems to be not 2.2.3 tag on doctrine/common ? May be you could submit a PR with the fix ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed no 2.2.3 tag in common. It will be the next 2.2.x release in common. The fix we need is not yet part of any doctrine release.

"autoload": {
"psr-0": { "Symfony\\Bridge\\Doctrine": "" }
Expand Down