[Process] fix tests #51297
Merged
[Process] fix tests #51297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db21813 to
3a042e9
Compare
stloyd
reviewed
Aug 7, 2023
| @@ -98,6 +98,7 @@ public function testFindWithOpenBaseDir() | |||
| $this->markTestSkipped('Cannot test when open_basedir is set'); | |||
| } | |||
|
|
|||
| putenv('PATH='.\dirname(\PHP_BINARY)); | |||
There was a problem hiding this comment.
Shouldn't be restored to previous value at end of the test?
There was a problem hiding this comment.
3a042e9 to
4ca4417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testFindProcessInOpenBasediris a duplicate oftestFindWithOpenBaseDirtestFindWithOpenBaseDircurrently expects that we search open_basedir instead of PATH when the setting is set, but this doesn't really make sense, and [Process] Support usingProcess::findExecutable()independently ofopen_basedir#47422 removed this behaviorPhpSubprocessTest::testSubprocessexpects a php that defaults to memory_limit=-1, which is not the case currently for the sigchild-enabled binary