[FrameworkBundle] add missing default-doctrine-dbal-provider cache pool attribute to XSD #51301
Conversation
xabbuh
commented
Aug 7, 2023
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
| @@ -290,6 +290,7 @@ | |||
| <xsd:element name="default-psr6-provider" type="xsd:string" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="default-redis-provider" type="xsd:string" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="default-memcached-provider" type="xsd:string" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="default-doctrine-dbal-provider" type="xsd:string" minOccurs="0" maxOccurs="1" /> | |||
There was a problem hiding this comment.
this should be an attribute, not an element, to match our XML conventions. The other xsd:string elements that cannot occur multiple times should have been attributes too, and we already added them as attributes when documenting the XML config and finding this out. So I suggest that new settings are added only as attribute to avoid continuing the non-conventional format.
And what is the difference between default-doctrine-dbal-provider and default-doctrine-provider ?
There was a problem hiding this comment.
I favor consistency on this one.
And what is the difference between default-doctrine-dbal-provider and default-doctrine-provider ?
default-doctrine-provider should have been named default-doctrine-cache-provider, it's using an adapter to doctrine/cache
|
Thank you @xabbuh. |
…to XML attribute (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] change default doctrine DBAL provider to XML attribute | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #51301 (comment) | License | MIT | Doc PR | Commits ------- e8a2e86 change default doctrine DBAL provider to XML attribute