Skip to content

[HttpFoundation] Add HeaderRequestMatcher #51343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2024
Merged

[HttpFoundation] Add HeaderRequestMatcher #51343

merged 1 commit into from
Feb 3, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Aug 10, 2023 •
edited by OskarStark
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets NA
License MIT
Doc PR Todo

This a follow up to:

After @norkunas' comment

@carsonbot carsonbot added this to the 6.4 milestone Aug 10, 2023
@alexandre-daubois alexandre-daubois mentioned this pull request Aug 10, 2023
Merged
@alexandre-daubois alexandre-daubois force-pushed the header-request-matcher branch 3 times, most recently from 04c0875 to 2366707 Compare August 11, 2023 11:02
@alexandre-daubois
Copy link
Member Author

Status: Needs Review

@alexandre-daubois
Copy link
Member Author

Rebased and conflicts fixed

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@alexandre-daubois
Copy link
Member Author

Rebased and conflicts fixed 🙂 (as well as this other related PR)

@OskarStark OskarStark requested a review from derrabus December 29, 2023 22:17
@fabpot fabpot force-pushed the header-request-matcher branch from 557d2b7 to 62b5a34 Compare February 3, 2024 16:12
@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 1e358d9 into symfony:7.1 Feb 3, 2024
@fabpot fabpot mentioned this pull request Feb 3, 2024
Closed
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas left review comments

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@stof stof stof approved these changes

@OskarStark OskarStark OskarStark approved these changes

@94noni 94noni 94noni approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Feature HttpFoundation Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
10 participants
@alexandre-daubois @fabpot @GromNaN @stof @OskarStark @94noni @derrabus @norkunas @nicolas-grekas @carsonbot