[FrameworkBundle][Validator] Deprecate annotation occurrences #51425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
606ec10 to
3d5557b
Compare
|
This should be in the same PR than #51426 instead of being a separate PR IMO, as this is about the FrameworkBundle semantic configuration related to the same change. |
97dc60e to
0bd8e1f
Compare
derrabus
reviewed
Aug 18, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Mapping/Loader/AttributeLoader.php
Outdated
Show resolved
Hide resolved
89a4e3c to
1723d35
Compare
1723d35 to
0a1cb09
Compare
nicolas-grekas
approved these changes
Aug 21, 2023
mtarld
approved these changes
Aug 22, 2023
derrabus
requested changes
Aug 22, 2023
0a1cb09 to
c315bd5
Compare
c315bd5 to
2e1e805
Compare
|
Addressed your comments @derrabus, thank you! |
derrabus
approved these changes
Aug 22, 2023
|
Thank you @alexandre-daubois. |
|
Working on the clean-up 👍 |
This was referenced Aug 22, 2023
derrabus
added a commit
that referenced
this pull request
Aug 23, 2023
…to AnnotationLoader (derrabus) This PR was merged into the 6.4 branch. Discussion ---------- [Validator] Un-deprecate passing an annotation reader to AnnotationLoader | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Follow-up to #51425 | License | MIT | Doc PR | N/A #51425 deprecated the `AnnotationLoader` class and its replacement already does not accept an annotation reader anymore. Thus, the deprecation of the constructor parameter is redundant, which is why I propose to take it back. cc `@alexandre`-daubois Commits ------- 4fa1d32 [Validator] Un-deprecate passing an annotation reader to AnnotationLoader
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2023
…ns (alexandre-daubois) This PR was merged into the 7.0 branch. Discussion ---------- [FrameworkBundle][Validator] Remove remaining deprecations | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#18781 Follow-up of #51425 Commits ------- 6e8cab7 [FrameworkBundle][Validator] Remove remaining deprecations
This was referenced Oct 21, 2023
Merged
Merged
|
see #52287 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framework.validation.enable_annotationsin favor offramework.validation.enable_attributesframework.serializer.enable_annotationsin favor of useframework.serializer.enable_attributesValidatorBuilder::enableAnnotationMapping()in favor ofValidatorBuilder::enableAttributeMapping()ValidatorBuilder::disableAnnotationMapping()in favor ofValidatorBuilder::disableAttributeMapping()AnnotationLoaderin favor ofAttributeLoader