Skip to content

[Serializer] Fix wrong InvalidArgumentException thrown #51474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2023
Merged

[Serializer] Fix wrong InvalidArgumentException thrown #51474

merged 1 commit into from
Aug 26, 2023

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Aug 24, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Throw the InvalidArgumentException of Serializer namespace instead of the PropertyAccess's one.

@mtarld mtarld requested a review from dunglas as a code owner August 24, 2023 14:31
@carsonbot carsonbot added this to the 5.4 milestone Aug 24, 2023
@mtarld mtarld mentioned this pull request Aug 24, 2023
Merged
@fabpot
Copy link
Member

fabpot commented Aug 26, 2023

Thank you @mtarld.

@fabpot fabpot merged commit 182d915 into symfony:5.4 Aug 26, 2023
This was referenced Aug 26, 2023
Merged
Merged
@mtarld mtarld deleted the fix/throw-proper-invalid-argument-exception branch August 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mtarld @fabpot @carsonbot