Skip to content

[Serializer] Fix union of enum denormalization #51475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2023
Merged

[Serializer] Fix union of enum denormalization #51475

merged 1 commit into from
Aug 26, 2023

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Aug 24, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47797
License MIT
Doc PR

Try other types when a InvalidArgumentException occurs for a union type.

@mtarld mtarld requested a review from dunglas as a code owner August 24, 2023 14:34
@carsonbot carsonbot added this to the 6.3 milestone Aug 24, 2023
@mtarld mtarld force-pushed the fix/invalid-enum-union-type branch from fe49e3b to 11378ef Compare August 24, 2023 14:35
@mtarld
Copy link
Contributor Author

mtarld commented Aug 24, 2023

fabbot warnings false positive here.

@mtarld mtarld mentioned this pull request Aug 24, 2023
Closed
@fabpot
Copy link
Member

fabpot commented Aug 26, 2023

Thank you @mtarld.

@fabpot fabpot merged commit 667db5d into symfony:6.3 Aug 26, 2023
This was referenced Aug 26, 2023
Closed
Closed
Merged
@mtarld mtarld deleted the fix/invalid-enum-union-type branch August 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mtarld @fabpot @carsonbot