-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Add Default and "class name" default groups #51514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eff6428
to
6147e64
Compare
Failing tests might be fixed thanks to #52646 |
nicolas-grekas
approved these changes
Nov 20, 2023
6147e64
to
a440104
Compare
Good PR! |
hnccox-yard
reviewed
Jan 8, 2024
a440104
to
8f052f1
Compare
fabpot
approved these changes
Feb 3, 2024
8f052f1
to
de58759
Compare
Thank you @mtarld. |
Merged
fabpot
added a commit
that referenced
this pull request
Nov 9, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Revert Default groups | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58576, Fix #57350 | License | MIT When introduced in #51514, the behavior of group selection was wrong and introduced BC breaks (see the two related issues). This PR reverts this introduction so that they can be added properly in 7.3 (see #58656). Commits ------- ab3220f [Serializer] Revert default groups
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 13, 2024
…p change (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] remove note about the reverted Default group change revert #19526 as symfony/symfony#51514 was reverted in symfony/symfony#58705 Commits ------- 626d56e remove note about the reverted Default group change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Default
and "class name" groups to the (de)normalization context, following Validator's component naming convention.