Skip to content

[Serializer] Add Default and "class name" default groups #51514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Aug 29, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #32622
License MIT
Doc PR TODO

Add Default and "class name" groups to the (de)normalization context, following Validator's component naming convention.

@mtarld
Copy link
Contributor Author

mtarld commented Nov 20, 2023

Failing tests might be fixed thanks to #52646

@nicolas-grekas nicolas-grekas changed the title [Serializer] Add default groups [Serializer] Add Default and "class name" default groups Nov 20, 2023
@OrigamiKill
Copy link

Good PR!

@mtarld mtarld force-pushed the feat/default-group branch from a440104 to 8f052f1 Compare January 10, 2024 08:18
@fabpot fabpot force-pushed the feat/default-group branch from 8f052f1 to de58759 Compare February 3, 2024 15:40
@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

Thank you @mtarld.

fabpot added a commit that referenced this pull request Nov 9, 2024
This PR was merged into the 7.1 branch.

Discussion
----------

[Serializer] Revert Default groups

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58576, Fix #57350
| License       | MIT

When introduced in #51514, the behavior of group selection was wrong and introduced BC breaks (see the two related issues).

This PR reverts this introduction so that they can be added properly in 7.3 (see #58656).

Commits
-------

ab3220f [Serializer] Revert default groups
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Nov 13, 2024
…p change (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[Serializer] remove note about the reverted Default group change

revert #19526 as symfony/symfony#51514 was reverted in symfony/symfony#58705

Commits
-------

626d56e remove note about the reverted Default group change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializer default groups
6 participants