[Config] Allow to always use config classes #51544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this, it's related to the limitation I found in #51273 |
| @@ -374,7 +374,7 @@ protected function createNode(): NodeInterface | |||
|
|
|||
| if ($this->default) { | |||
| if (!\is_array($this->defaultValue)) { | |||
| throw new \InvalidArgumentException(sprintf('%s: the default value of an array node has to be an array.', $node->getPath())); | |||
| throw new \InvalidArgumentException(sprintf('"%s": the default value of an array node has to be an array.', $node->getPath())); | |||
There was a problem hiding this comment.
should be reverted, that's a false-positive from fabbot I suppose
| protected $node; | ||
|
|
||
| public $allowedTypes; |
There was a problem hiding this comment.
removing consts and public properties is a BC break, we need to figure out a way that doesn't break BC
- undo changes from symfony#44166
f4bb242 to
72e1fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config node doesn't have normalization, using the config object is impossible.
When the config node has some array normalization (like
http_codesin\Symfony\Bundle\FrameworkBundle\DependencyInjection\Configuration::addHttpClientRetrySection), it is not possible to use the config object.This PR relates to changes introduced in: