[Security] Add badge resolution to profiler #51585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Sep 7, 2023
src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig
Outdated
Show resolved
Hide resolved
94noni
reviewed
Sep 7, 2023
src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig
Show resolved
Hide resolved
fabpot
approved these changes
Sep 10, 2023
6 tasks
|
Thank you @Jean-Beru. |
3a810c1 to
2324da2
Compare
|
Composer updated a stable project and now broken :(
|
|
ok on debugging I can see that on the login request, when viewed In debugger, I can see the badges - so the point of this PR is working fine. But after login when redirected to the user dashboard of the app, and trying to load any page when already logged in, then the passport is null in the TraceableAuthenticator and this means the whole app is down with the error previously provided. Changing
|
|
Would you mind sending a PR (with test ideally)? |
|
like this #51612 ? |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2023
…th (PhilETaylor) This PR was merged into the 6.4 branch. Discussion ---------- [Security] Fix for TraceableAuthenticator debug when no Auth | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #51585 (comment) | License | MIT Fixes regression in PR #51585 and adds unit test  Commits ------- a9d36a5 Fix for TraceableAuthenticator debug when no Auth
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add badges resolution status in Security profiler as mentioned in #36668 (" See which badges are resolved and which aren't").
CSRF error
Wrong credentials
Authentication successful