[Mime] Allow to add some headers as a strings #51601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. We don't allow merge commits. Please perform a rebase and squash your commits. |
|
In addition to the !is_array verification, verifying that it's a string should be added no? |
|
When something other than a string is passed, the message seems rather explicit. Argument #2 ($value) must be of type string, DateTime given What do you think should happen if you don't have a string? |
derrabus
approved these changes
Sep 18, 2023
This is fine, I think. |
maxbeckers
approved these changes
Sep 20, 2023
|
Thank you @Oipnet. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a MailboxListHeader header, the constructor expects an array as parameter.
To simplify the UX, we now allow you to pass a string to the addHeader method in the case of a MailBoxListHeader. The header value is then converted to an array.