Skip to content

[Doctrine][Messenger] Remove obsolete DBAL 2 compat code #51615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

DBAL 2's forward compatibility layer should allow us to remove this feature detection.

@carsonbot carsonbot added this to the 6.4 milestone Sep 10, 2023
@carsonbot carsonbot changed the title Remove obsolete DBAL 2 compat code [Doctrine][Messenger] Remove obsolete DBAL 2 compat code Sep 10, 2023
@fabpot
Copy link
Member

fabpot commented Sep 10, 2023

Thank you @derrabus.

@fabpot fabpot merged commit 24b1bc8 into symfony:6.4 Sep 10, 2023
@derrabus derrabus deleted the remove/dbal-2-sniff branch September 10, 2023 17:08
derrabus added a commit that referenced this pull request Sep 11, 2023
This PR was merged into the 6.4 branch.

Discussion
----------

[Messenger] Fix DoctrineIntegrationTest

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Follows #51615
| License       | MIT
| Doc PR        | N/A

Fixes a DBAL 2 incompatibility introduced by #51615.

Commits
-------

c980956 [Messenger] Fix DoctrineIntegrationTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants