[Messenger] RejectRedeliveredMessageException should not be retried #51756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdd715c to
67790f3
Compare
fabpot
approved these changes
Sep 30, 2023
|
Thank you @nikophil. |
This was referenced Oct 21, 2023
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Mar 12, 2024
…ry (nikophil) This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] trigger retry logic when message is a redelivery | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52903 #53311 | License | MIT This PR rollbacks #51756 which was an error ping `@itcodeOstrowski` `@beermeat` Commits ------- e397200 [Messenger] trigger retry logic when message is a redelivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
when a
RejectRedeliveredMessageExceptionis thrown once, it is actually retried because it does not implementUnrecoverableExceptionInterfacebut we know it will always because the stampAmqpReceivedStampwill always be there