[Cache] Fix two initializations of Redis Sentinel #51775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Sep 28, 2023
|
Thank you @digilist. |
|
As you said in #51687 (comment) that you copied the bad usage of SkippedTestSuiteError from the tests of the Cache component, maybe you could update the test too (assuming older branches don't also need the fix, in which case a separate PR is better) |
|
Yep. Since this PR is already merged I opened a new PR for it. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 28, 2023
…pped() call (digilist) This PR was merged into the 6.4 branch. Discussion ---------- Replace usages of SkippedTestSuiteError with markTestSkipped() call | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT Just a simple clean up to replace the usages of `SkippedTestSuiteError` with a call to `markTestSkipped()`. This is a follow up for #51775. Commits ------- 41eb669 Replace usages of SkippedTestSuiteError with markTestSkipped() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #51687 and #51683 have been merged, there are now two initializations of Redis Sentinel, which also leads to the integration test failure mentioned in this comment. This PR fixes this.