[WebProfiler] Profiler improvements / extract Font from stylesheet #51888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features". Cheers! Carsonbot |
66c38df to
4663658
Compare
|
I'm having troubles with tests... i'll fix / ask help just after the implementation feedback . |
|
The Twig changes made those last 24h may explain (at least partially) my troubles with the tests |
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/fonts/JetBrainsMono.woff2
Outdated
Show resolved
Hide resolved
stof
reviewed
Oct 9, 2023
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
|
Test errors are now unrelated |
|
Is there anything else i can do ? Should i rebase the commits ? |
javiereguiluz
approved these changes
Oct 9, 2023
fabpot
reviewed
Oct 10, 2023
ro0NL
reviewed
Oct 10, 2023
| @@ -1,5 +1,5 @@ | |||
| <div id="header"> | |||
| <h1>{{ source('@WebProfiler/Icon/symfony.svg') }} Symfony Profiler</h1> | |||
| <h1><a href="{{ path('_profiler_home') }}">{{ source('@WebProfiler/Icon/symfony.svg') }} Symfony Profiler</a></h1> | |||
fabpot
approved these changes
Oct 11, 2023
ba8f962 to
a78ec8d
Compare
|
Thank you @smnandre. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove 30% of profiler responses size, removing unused font/data64
AndMore 1 - fixed a couple of CSS bugs
AndMore 2 - made the logo clickable, allowing anyone to quickly returning to the profiler homepage
In the HTML source code of every profiler page (excluding the toolbar) .... was inejected around 100KB of base64 encoded font.
With the raise of ui / system fonts, the adoption of HTTP2, and all the other techniques to handle assets in a simplier way... i think we have to improve this (minor) situation.
This PR
extract the wofffile in its own file, handled by the Profiler controller, and leverage the "local" stores.Result: 30%of immediate reduction
Now it's