[Serializer] Fix collecting only first missing constructor argument #51907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your solution looks great, but I see a conflict with RequestMapper. Do you tested your solution with PayloadMapper in 6.3? |
258ae0f to
cd90ab7
Compare
|
@y4roc Hi, you were right, my changes did cause an issue with the |
HypeMC
commented
Oct 10, 2023
| @@ -412,24 +413,26 @@ protected function instantiateObject(array &$data, string $class, array &$contex | |||
| true | |||
| ); | |||
| $context['not_normalizable_value_exceptions'][] = $exception; | |||
|
|
|||
| return $reflectionClass->newInstanceWithoutConstructor(); | |||
There was a problem hiding this comment.
This is now handled in the try...catch block.
nicolas-grekas
approved these changes
Oct 17, 2023
cd90ab7 to
0f398ce
Compare
|
Thank you @HypeMC. |
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix denormalize constructor arguments | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52499, Fix #52422 | License | MIT Since this PR: #51907, objects with partial constructor parameters were wrongly instantiated. This PR fixes that issue by delegating the properties values assignment, by unsetting normalized data only when the constructor has been called properly. This might correct #50759 as well. Commits ------- 8f7c7ae [Serializer] Fix denormalize constructor arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #51866, sort of followup to #49832
Currently on 5.4 only the first exception is added to the
not_normalizable_value_exceptionsarray whenCOLLECT_DENORMALIZATION_ERRORSistrueor only the first argument is mentioned in theMissingConstructorArgumentsExceptionwhen it isfalse.On 6.3 however, the part with the
MissingConstructorArgumentsExceptionwas fix with #49832, but the part with thenot_normalizable_value_exceptionswas overlooked.IMO this is inconsistent behavior as the two cases are actually the same thing with the only difference being that in one case an exception is thrown while in the other the errors are collected.
I'm not sure if #51866 really qualifies as a bug or is actually more a feature, but the reason #49832 was merged onto 6.3 was because of the changes originally done in #49013, which itself was a feature.
If #51866 does qualify as a bug then it would make sense to backport #49832 to 5.4 for consistency, which is what this PR does.
The PR contains two commits:
If #51866 does not qualify as a bug, the first commit can be drooped and the second one can be rebased with 6.4.
PS I think it's easier to review the changes commit by commit.