-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] PhpUnit assert Messenger #51964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.4
Are you sure you want to change the base?
[FrameworkBundle] PhpUnit assert Messenger #51964
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
4fa419f
to
35def9d
Compare
src/Symfony/Component/Messenger/EventListener/MessagesSentToTransportsListener.php.orig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyQuery.php
Outdated
Show resolved
Hide resolved
Labelling the PR as PhpUnitBridge is wrong as this adds the feature in FrameworkBundle. |
34956ed
to
fbaeb1c
Compare
fbaeb1c
to
324586c
Compare
src/Symfony/Bundle/FrameworkBundle/Test/MessengerAssertionsTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Test/MessengerAssertionsTrait.php
Outdated
Show resolved
Hide resolved
09e6f34
to
0398f6e
Compare
* @param string|null $busName The busName to consider | ||
* @param string|null $messageFQCN The message object class name to consider | ||
*/ | ||
public static function assertMessagesCount(int $count, string $busName = null, string $messageFQCN = null, string $message = ''): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small suggestion : I think assetMessageCount
(without the 's') would be more 'correct' 😃
0398f6e
to
a96e01c
Compare
a96e01c
to
2ed780c
Compare
Hello,
This MessengerAssertionTrait is a Helper for those who want to be able to test the dispatched messages while working with Messenger.
Hope this helps!
Regards,
Marilena Ruffelaere