Skip to content

[Console] Dispatch ConsoleTerminateEvent when exiting on signal #52038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Console] Dispatch ConsoleTerminateEvent when exiting on signal #52038

merged 1 commit into from
Oct 13, 2023

Conversation

HeahDude
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets ~
License MIT

Extracted from #47416. /cc @lyrixx @chalasr

@HeahDude HeahDude requested a review from chalasr as a code owner October 13, 2023 09:35
@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2023
@HeahDude HeahDude force-pushed the feat/signal-exit-dispatch branch from 29cc22a to a73762c Compare October 13, 2023 09:39
@chalasr
Copy link
Member

chalasr commented Oct 13, 2023

Thank you @HeahDude.

@chalasr chalasr merged commit 825ae03 into symfony:6.4 Oct 13, 2023
This was referenced Oct 13, 2023
Closed
Merged
@HeahDude HeahDude deleted the feat/signal-exit-dispatch branch October 13, 2023 09:55
@OskarStark
Copy link
Contributor

PR created at 11:35
Merged at 11:53
Docs Issue created at 11:53
Docs PR created at 12:00
Docs PR merged at 12:26

Thats under an hour 🥳 ❤️ 🚀

This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@HeahDude @chalasr @OskarStark @lyrixx @carsonbot