Skip to content

[Console] Fix allow passing a default argument when InputOption::IS_NEGATABLE is used #52058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 5.4
Choose a base branch
from
Open

[Console] Fix allow passing a default argument when InputOption::IS_NEGATABLE is used #52058

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eab830
Add test for failing input mode
jnoordsij Oct 14, 2023
7ec91b4
Allow default values for negatable input in InputOption
jnoordsij Oct 14, 2023
ba2f4a5
Add test to ensure default value is allowed with InputOption::VALUE_N…
jnoordsij Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for failing input mode
  • Loading branch information
@jnoordsij
jnoordsij committed Oct 14, 2023
commit 5eab830ebabf8518f47911560ccd321c19b7da0b
6 changes: 6 additions & 0 deletions src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,12 @@ public static function provideNegatableOptions()
['foo' => false],
'->parse() parses long options without a value',
],
[
['cli.php'],
[new InputOption('foo', null, InputOption::VALUE_NONE | InputOption::VALUE_NEGATABLE, '', false)],
['foo' => false],
'->parse() parses long options without a value',
],
];
}

Expand Down