Skip to content

[Messenger] Add ext-pcntl to composer.json #52129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Messenger] Add ext-pcntl to composer.json #52129

wants to merge 1 commit into from

Conversation

beesofts
Copy link

Since ConsumeMessagesCommand.php uses SIGTERM and SIGINT, ext-pcntl must be available on system

Since ConsumeMessagesCommand.php uses SIGTERM and SIGINT, ext-pcntl must be available on system
@carsonbot carsonbot added this to the 6.4 milestone Oct 18, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Oct 18, 2023

It's optional.
Maybe #51791 is what you're looking for.

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will basically forbid installing messenger on Windows. 👎🏻

@carsonbot carsonbot changed the title Add ext-pcntl to composer.json [Messenger] Add ext-pcntl to composer.json Oct 18, 2023
@derrabus derrabus closed this Oct 18, 2023
@SerheyDolgushev
Copy link
Contributor

@beesofts can you please check #52586 and confirm it describes your case?

@beesofts
Copy link
Author

in my point of view, https://github.com/symfony/symfony/pull/51791/files did the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants