[HttpKernel] Fix RequestPayloadValueResolver handling error with no ExpectedTypes
#52131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
800fb4b to
26cee32
Compare
maxhelias
approved these changes
Dec 11, 2023
chalasr
approved these changes
Jan 29, 2024
|
Could you please rebase? |
26cee32 to
0af85fe
Compare
|
Thank you @Jeroeny. |
| @@ -108,11 +108,15 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo | |||
| } catch (PartialDenormalizationException $e) { | |||
| $trans = $this->translator ? $this->translator->trans(...) : fn ($m, $p) => strtr($m, $p); | |||
| foreach ($e->getErrors() as $error) { | |||
| $parameters = ['{{ type }}' => implode('|', $error->getExpectedTypes())]; | |||
| $parameters = []; | |||
| $template = 'This value was of an unexpected type.'; | |||
There was a problem hiding this comment.
Note that this message is not in translation maps. Dunno if it matters. Does it?
This was referenced Jan 30, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NotNormalizableValueExceptionerrors inPartialDenormalizationException->getErrors()have a->getExpectedTypes()method that returnsarray|null. TheRequestPayloadValueResolverassumes this is always an array.When the returned value is
null, an Exception is thrown withimplode(): Argument #1 ($pieces) must be of type array, string given.Also the exception message in case of an empty array was:
This value should be of type ..#SymfonyHackday