Skip to content

[Console] Fix horizontal table top border is incorrectly rendered #52132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Console] Fix horizontal table top border is incorrectly rendered #52132

merged 1 commit into from
Oct 31, 2023

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Oct 18, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #52101
License MIT

cc @alainrinder

@OskarStark OskarStark requested a review from chalasr as a code owner October 18, 2023 09:15
@carsonbot carsonbot added this to the 6.3 milestone Oct 18, 2023
@OskarStark OskarStark mentioned this pull request Oct 18, 2023
Closed
@OskarStark
Copy link
Contributor Author

Fabbot is false positive

@GromNaN
Copy link
Member

GromNaN commented Oct 18, 2023

The issue might be with unicode characters. Could you add an emoji in the values?

@OskarStark
Copy link
Contributor Author

The issue might be with unicode characters. Could you add an emoji in the values?

Lets try the fix from the bug report

@OskarStark OskarStark changed the title [Console] Add tests [Console] Fix table rendering Oct 18, 2023
@OskarStark OskarStark self-assigned this Oct 18, 2023
@OskarStark
Copy link
Contributor Author

What's the difference here?
CleanShot 2023-10-18 at 11 47 39@2x

@OskarStark OskarStark changed the title [Console] Fix table rendering [Console] Fix horizontal table top border is incorrectly rendered Oct 19, 2023
@OskarStark OskarStark force-pushed the fix/console-table-border branch from b058fc8 to 00f0d34 Compare October 20, 2023 07:35
OskarStark
OskarStark commented Oct 20, 2023
View reviewed changes
src/Symfony/Component/Console/Helper/Table.php
@@ -411,7 +411,7 @@ public function render()

if ($isHeader && !$isHeaderSeparatorRendered) {
$this->renderRowSeparator(
$isHeader ? self::SEPARATOR_TOP : self::SEPARATOR_TOP_BOTTOM,
self::SEPARATOR_TOP,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this, because $isHeader is always true

@OskarStark OskarStark requested a review from fabpot October 20, 2023 07:50
@OskarStark OskarStark requested a review from xabbuh October 20, 2023 15:00
@nicolas-grekas nicolas-grekas force-pushed the fix/console-table-border branch from 6857bfa to 6ef10c1 Compare October 31, 2023 08:09
@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 7a59ef0 into symfony:6.3 Oct 31, 2023
@OskarStark OskarStark deleted the fix/console-table-border branch October 31, 2023 08:13
This was referenced Nov 10, 2023
Merged
Merged
Merged
renovate bot added a commit to Lendable/composer-license-checker that referenced this pull request Nov 13, 2023
@renovate
Update dependency symfony/console to v6.3.8 (#217)
1105d33 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [symfony/console](https://symfony.com)
([source](https://togithub.com/symfony/console)) | `6.3.4` -> `6.3.8` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fconsole/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fconsole/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fconsole/6.3.4/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fconsole/6.3.4/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>symfony/console (symfony/console)</summary>

### [`v6.3.8`](https://togithub.com/symfony/console/releases/tag/v6.3.8)

[Compare
Source](https://togithub.com/symfony/console/compare/v6.3.4...v6.3.8)

**Changelog**
(symfony/console@v6.3.7...v6.3.8)

- bug
[symfony/symfony#52132](https://togithub.com/symfony/symfony/issues/52132)
\[Console] Fix horizontal table top border is incorrectly rendered
([@&#8203;OskarStark](https://togithub.com/OskarStark))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/composer-license-checker).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordinskiy gordinskiy gordinskiy left review comments

@maxbeckers maxbeckers maxbeckers approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

@fabpot fabpot Awaiting requested review from fabpot

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

@OskarStark OskarStark

Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@OskarStark @GromNaN @nicolas-grekas @maxbeckers @gordinskiy @carsonbot