Skip to content

[WebProfilerBundle] Rewrite to avoid using request word when nothing found #52155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

When profiling commands, we don't have request.

image

Others collectors templates don't use "Request" when there is no item

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@fabpot
Copy link
Member

fabpot commented Oct 19, 2023

Good catch, thanks @alamirault.

@fabpot fabpot merged commit 737613c into symfony:6.4 Oct 19, 2023
@alamirault alamirault deleted the feature/profile-remove-request-in-wording-when-nothing branch October 19, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants