[AssetMapper] Optimize memory usage (load only "compilable" assets) #52156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/AssetMapper/Factory/MappedAssetFactory.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Oct 19, 2023
stof
reviewed
Oct 19, 2023
weaverryan
approved these changes
Oct 19, 2023
|
Should i do something special for the Psalm alert ? The code is safe and "hash_file" will return a string, but Psalm has no way to know the file existence has just been tested.... and i don't want to check it twice in the code. |
|
Nope, you can ignore psalm, we didn't surrender to robots (yet) ;) |
|
So all is ok for me :) |
fabpot
approved these changes
Oct 20, 2023
2fe6f9a to
9f63c81
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit late for 6.4... but this PR will have a sensible impact on performances.
Currently if the assets directory contains 500 images, they are all loaded in memory during the compile command.
Their contents are also serialized/unserialized and stored in cache.
This PR allow to load/store in memory/cache only the assets supported by the compilers (JS/CSS files today)