Skip to content

[Tests] Move expectException closer to the place of the expectation to avoid false positives #52157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Tests] Move expectException closer to the place of the expectation to avoid false positives #52157

merged 1 commit into from
Oct 31, 2023

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Oct 19, 2023 •
edited
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets --
License MIT

If you guys like this PR, I will fix the other places as well

Should be merged after merge & upmerge of:

@OskarStark OskarStark requested a review from stof October 19, 2023 05:17
@carsonbot carsonbot added this to the 6.4 milestone Oct 19, 2023
@OskarStark OskarStark requested a review from derrabus October 19, 2023 06:50
@OskarStark OskarStark requested a review from chalasr as a code owner October 30, 2023 08:23
@OskarStark OskarStark mentioned this pull request Oct 30, 2023
Merged
@nicolas-grekas
Copy link
Member

  1. Symfony\Component\Console\Tests\Helper\TableTest::testThrowsWhenTheCellInAnArray
    Failed asserting that exception of type "Symfony\Component\Console\Exception\InvalidArgumentException" is thrown.

Related isn't it?

@OskarStark
Copy link
Contributor Author

Test failures unrelated

nicolas-grekas added a commit that referenced this pull request Oct 31, 2023
@nicolas-grekas
minor #52365 [Tests] Streamline (OskarStark)
b26fdd0 
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Tests] Streamline

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | --
| License       | MIT

Extracted from #52157

Commits
-------

918f677 [Tests] Streamline
@OskarStark
Copy link
Contributor Author

Test failures unrelated

@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 382564d into symfony:6.4 Oct 31, 2023
@keradus
Copy link
Member

keradus commented Oct 31, 2023 •
edited
Loading

❤️ for change!

If you guys like this PR, I will fix the other places as well

@OskarStark , if you are up for it, maybe a new Fixer rule?

@OskarStark OskarStark mentioned this pull request Nov 1, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Dec 26, 2023
@nicolas-grekas
minor #52402 [Tests] Streamline (OskarStark)
e6acb8c 
This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Tests] Streamline

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | --
| License       | MIT

Follows
* #52157
* #52365

Commits
-------

33d71aa [Tests] Streamline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @nicolas-grekas @keradus @stof @carsonbot