[Serializer] Add AbstractObjectNormalizer::ENABLE_TYPE_CONVERSION for scalar type transformation
#52173
+56
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b3d41f to
4690cbf
Compare
mtarld
requested changes
Oct 25, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
4690cbf to
2b9c192
Compare
2b9c192 to
dcd73a0
Compare
mtarld
requested changes
Nov 15, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
Jeroeny
commented
Nov 16, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
Jeroeny
commented
Nov 16, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
c8f87f4 to
76c5b26
Compare
Jeroeny
commented
Nov 16, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
Jeroeny
commented
Nov 16, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
mtarld
approved these changes
Nov 17, 2023
|
Needs rebase, thanks |
…e transformation
…alizer.php Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
…ctNormalizerTest.php Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
…ctNormalizerTest.php Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
…alizer.php Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
268726b to
67c1c50
Compare
|
Done |
OskarStark
reviewed
Jan 31, 2024
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AbstractObjectNormalizerconverts string types to other scalar types for the Xml and Csv format.This logic is quite useful for other untyped formats as well. Like data coming from a Http query.
It'd nice if the logic can be exposed via this new constant to be set in the
$context.