Skip to content

[AssetMapper] Fixing bug of bad parsing of imports when an import then export are adjacent #52200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[AssetMapper] Fixing bug of bad parsing of imports when an import then export are adjacent #52200

merged 1 commit into from
Oct 20, 2023

Conversation

weaverryan
Copy link
Member

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets See #52119 (comment) though this appears to be unrelated to that PR
License MIT

There should be a finite number of import statement formats. @tacman found a new one! :)

Cheers!

@carsonbot carsonbot added this to the 6.4 milestone Oct 20, 2023
@fabpot
Copy link
Member

fabpot commented Oct 20, 2023

Thank you @weaverryan.

@fabpot fabpot merged commit 3b02e73 into symfony:6.4 Oct 20, 2023
@weaverryan weaverryan deleted the asset-mapper-adjacent-import-export-statements branch October 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
AssetMapper Bug Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@weaverryan @fabpot @stof @carsonbot