[MonologBridge] Fix support for monolog 3.0 #52222
Conversation
7553021 to
107428f
Compare
|
Can you add a test to prevent future regressions? |
I think it's difficult in this PR to add test because mock stream functions will cause a refactoring of the command. |
8a05567 to
3555d5a
Compare
|
I don't know how to fix psalm error because in monolog 2.x, LogRecord is an interface and psalm runs with this version. |
| channel: $record['channel'], | ||
| context: $record['context']->getContext(), | ||
| datetime: $record['datetime'], | ||
| message: $record['message'], |
There was a problem hiding this comment.
let's not use named arguments if possible
There was a problem hiding this comment.
Ok I did the change. But why don't use named arguments ?
Named arguments are already used for the LogRecord.
|
Don't care about Psalm in this case. This is an expected error due to supporting several versions of Monolog. Our psalm setup only reports new issues for each PR, so this won't both future PRs. |
e5afa36 to
3aacc28
Compare
|
Good catch, thanks @louismariegaborit. |
…ouismariegaborit) This PR was merged into the 6.3 branch. Discussion ---------- [MonologBridge] Fix context data and display extra data | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | -> | License | MIT Fix the compatibility with Monolog 3. In the PR #52222 we had the compatibility with Monolog 3 but context parameter is incorrect and extra parameter is missing. No test can be added because testing this command is not possible at this time. Another PR (#53518) was opened to add test on this command. Commits ------- 8687ae0 Fix context data and display extra data
handlefunction in HandlerInterface supports only LogRecord argument in monolog 3.0.