Skip to content

[Messenger] declare constructor argument as optional for backwards compatibility #52232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

[Messenger] declare constructor argument as optional for backwards compatibility #52232

merged 1 commit into from
Oct 25, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 22, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #51468 (comment)
License MIT

@carsonbot carsonbot added this to the 6.3 milestone Oct 22, 2023
@ste93cry
Copy link
Contributor

Shouldn't a deprecation be triggered so that accepting a null value is not allowed anymore in the next major? This would make the behavior consistent with similar exceptions, e.g. HandlerFailedException

@xabbuh
Copy link
Member Author

xabbuh commented Oct 23, 2023

We cannot add new deprecations in already released minor versions.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 3a78c70 into symfony:6.3 Oct 25, 2023
@xabbuh xabbuh deleted the pr-51468 branch October 25, 2023 18:41
This was referenced Oct 29, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @ste93cry @nicolas-grekas @carsonbot