Skip to content

[Form] Skip merging params & files if there are no files in the first place #52255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Form] Skip merging params & files if there are no files in the first place #52255

merged 1 commit into from
Oct 24, 2023

Conversation

priyadi
Copy link
Contributor

@priyadi priyadi commented Oct 24, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52248
License MIT

Skip merging params & files if there are no files in the first place. Works around problems with numeric field names.

@carsonbot carsonbot added this to the 6.3 milestone Oct 24, 2023
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 24, 2023 •
edited
Loading

In addition, what about using array_is_list() to decide what to do with keys?

@priyadi
Copy link
Contributor Author

priyadi commented Oct 24, 2023

In addition, what about using array_is_list() to decide what to do with keys?

good idea. done.

@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 5.4 Oct 24, 2023
@nicolas-grekas nicolas-grekas changed the title Skip merging params & files if there are no files in the first place. Works around problems with numeric field names. Skip merging params & files if there are no files in the first place Oct 24, 2023
@carsonbot carsonbot changed the title Skip merging params & files if there are no files in the first place [Form] Skip merging params & files if there are no files in the first place Oct 24, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.3 to 5.4 October 24, 2023 09:12
@OskarStark
Copy link
Contributor

cc @dmaicher

@nicolas-grekas
Copy link
Member

Thank you @priyadi.

@nicolas-grekas nicolas-grekas merged commit b769b77 into symfony:5.4 Oct 24, 2023
@dmaicher
Copy link
Contributor

Thanks for the fast fix @priyadi @nicolas-grekas 🚀 👍

@xabbuh xabbuh mentioned this pull request Oct 27, 2023
Closed
This was referenced Oct 29, 2023
Merged
Merged
Merged
Merged
@Clement-B Clement-B mentioned this pull request Jan 2, 2024
Closed
@renovate renovate bot mentioned this pull request Jun 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@priyadi @nicolas-grekas @OskarStark @dmaicher @carsonbot