[FrameworkBundle] re-introduce conflict rule with WebProfilerBundle < 6.4 #52274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#52229 is not sufficient as we also would have had to remove the data collector service if the installed version of the WebProfilerBundle is not 6.4 or higher (otherwise the template would be missing). |
nicolas-grekas
approved these changes
Oct 24, 2023
derrabus
approved these changes
Oct 24, 2023
chalasr
approved these changes
Oct 24, 2023
|
Update: as i previously said, i just tried to find an other solution.. i made you lose enough time, so sorry for that and :) (and if there is a small bug, i'll find a repro and present a fix, basing it on your work) -- Original messageSorry if i made you lose time, i was suprised we needed that conflict when other profiler did not.So there is a problem, maybe not caused by this, but there is one. Try |
|
Thank you @xabbuh. |
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.