Skip to content

[Routing][Serializer] Add annotation -> attribute aliases #52294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Routing][Serializer] Add annotation -> attribute aliases #52294

merged 1 commit into from
Oct 30, 2023

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 25, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #51381
License MIT

@wouterj wouterj requested a review from dunglas as a code owner October 25, 2023 14:07
@carsonbot carsonbot added this to the 6.4 milestone Oct 25, 2023
@carsonbot carsonbot changed the title [Serializer][Routing] Add annotation -> attribute aliases [Routing][Serializer] Add annotation -> attribute aliases Oct 25, 2023
@wouterj wouterj mentioned this pull request Oct 25, 2023
Closed
7 tasks
@GromNaN
Copy link
Member

GromNaN commented Oct 25, 2023

This is going to conflict with PR on #51920.

@nicolas-grekas
Copy link
Member

There are some related failure to check ;)

@wouterj wouterj force-pushed the issue-51381/attribute-aliases branch from ee5e796 to 141ac47 Compare October 29, 2023 10:03
@wouterj wouterj force-pushed the issue-51381/attribute-aliases branch from 141ac47 to cce20a4 Compare October 29, 2023 16:00
@wouterj
Copy link
Member Author

wouterj commented Oct 29, 2023

Fixed lots of typos. I believe the high deps tests are fixed when this is up merged into 7.0, all other failure seem unrelated.

@nicolas-grekas
Copy link
Member

Thank you @wouterj.

@nicolas-grekas nicolas-grekas merged commit 4f0a585 into symfony:6.4 Oct 30, 2023
@wouterj wouterj deleted the issue-51381/attribute-aliases branch October 30, 2023 14:35
@GromNaN GromNaN mentioned this pull request Nov 1, 2023
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Routing Serializer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[RFC] Consistently use the word "attribute" in all symbols
6 participants
@wouterj @GromNaN @nicolas-grekas @derrabus @mtarld @carsonbot