Skip to content

DX: re-apply self_accessor and phpdoc_types_order by PHP CS Fixer #52321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2023
Merged

DX: re-apply self_accessor and phpdoc_types_order by PHP CS Fixer #52321

merged 1 commit into from
Oct 29, 2023
+9 −9

Conversation

keradus
Copy link
Member

@keradus keradus commented Oct 27, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix CS
License MIT

one further step to clean the CS status-quo, aiming for all-green in long-term

@carsonbot carsonbot added this to the 6.4 milestone Oct 27, 2023
@keradus keradus changed the title DX: re-apply self_accessor by PHP CS Fixer DX: re-apply self_accessor and phpdoc_types_order by PHP CS Fixer Oct 27, 2023
@nicolas-grekas
Copy link
Member

Thank you @keradus.

@nicolas-grekas nicolas-grekas merged commit 893329e into symfony:6.4 Oct 29, 2023
@keradus keradus deleted the self_accessor branch October 29, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@keradus @nicolas-grekas @carsonbot